Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.rst #5961

Closed
wants to merge 1 commit into from
Closed

Update README.rst #5961

wants to merge 1 commit into from

Conversation

eltociear
Copy link

Github -> GitHub

@eltociear
Update README.rst
8923720 
Github -> GitHub
@eltociear eltociear requested review from a team, vtomole and cduck as code owners December 14, 2022 15:56
@eltociear eltociear requested a review from pavoljuhas December 14, 2022 15:56
@CirqBot CirqBot added the Size: XS <10 lines changed label Dec 14, 2022
vtomole
vtomole requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this.

It's correct, but if we do this we'll have to find all the other instances in this repo and change it to this. For example in dev/development.md we say your github id when we should be saying your GitHub id.

dstrain115 added a commit to dstrain115/Cirq-1 that referenced this pull request Mar 20, 2024
@dstrain115
Fix capitalization of GitHub in docs
773d235 
- Saw an old PR to replace Github with proper capitalization of GitHub.
- This PR does this on a more consistent basis and updates that PR.
- Replaces quantumlib#5961
@dstrain115 dstrain115 mentioned this pull request Mar 20, 2024
Merged
@dstrain115
Copy link
Collaborator

This PR is out of date. Closing and will replace with #6509

@dstrain115 dstrain115 closed this Mar 20, 2024
dstrain115 added a commit that referenced this pull request Mar 20, 2024
@dstrain115
Fix capitalization of GitHub in docs (#6509)
42927b8 
- Saw an old PR to replace Github with proper capitalization of GitHub.
- This PR does this on a more consistent basis and updates that PR.
- Replaces #5961
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@dstrain115 @jselig-rigetti
Fix capitalization of GitHub in docs (quantumlib#6509)
e3f7cf3 
- Saw an old PR to replace Github with proper capitalization of GitHub.
- This PR does this on a more consistent basis and updates that PR.
- Replaces quantumlib#5961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole requested changes

@cduck cduck Awaiting requested review from cduck

@pavoljuhas pavoljuhas Awaiting requested review from pavoljuhas pavoljuhas is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eltociear @dstrain115 @vtomole @CirqBot