Make AsyncioExecutor a shared resource across EngineClients #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcourtney
requested review from
a team,
vtomole,
cduck and
verult
as code owners
maffoo
reviewed
Jan 4, 2023
| @@ -124,7 +130,7 @@ def __init__( | |||
|
|
|||
| @cached_property | |||
There was a problem hiding this comment.
I'd suggest removing this cached_property decorator since there's no need to cache on each EngineClient instance as well as on the AsyncExecutor class.
Co-authored-by: Matthew Neeley <maffoo@google.com>
maffoo
approved these changes
Jan 5, 2023
maffoo
reviewed
Jan 5, 2023
| @@ -122,9 +130,10 @@ def __init__( | |||
|
|
|||
| self._service_args = service_args | |||
|
|
|||
| @cached_property | |||
There was a problem hiding this comment.
Oops, need to add back @property since other places in the code call this like a property instead of a method.
There was a problem hiding this comment.
Makes sense. Fixed and tested; thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues in grpc/grpc#25364.