Bump node-fetch and puppeteer in /cirq-web/cirq_ts #5998
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) to 2.6.9 and updates ancestor dependency [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together. Updates `node-fetch` from 2.6.1 to 2.6.9 - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.9) Updates `puppeteer` from 10.0.0 to 19.6.3 - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@v10.0.0...puppeteer-v19.6.3) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect - dependency-name: puppeteer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
a team,
vtomole and
cduck
as code owners
dependabot
bot
added
dependencies
area/javascript
|
@seunomonije - I hope all is going great, would you mind taking a quick look? |
|
Thanks to wcourtney for updating expected PNGs. The tests are passing locally on Debian-like OS, but failing on GHA. |
|
I can take a look, sometimes chrome updates can cause matchers to fail and you have to use another matcher that is compatible with the new update. |
|
Thank you @senecameeks for helping with this, let me know if you have any questions. |
…ode-fetch-and-puppeteer-2.6.9
|
@senecameeks - there is a related PR #6014; it seems that ci.yml was missing |
…ode-fetch-and-puppeteer-2.6.9
|
@pavoljuhas Changed to |
the test is passing on my debian box with identical PNGs. |
|
If reverting doesn't work, we can try treating the pngs as binary files (https://blog.jongallant.com/2021/02/png-files-not-rendering-on-github/) Adding I haven't gotten the tests to run properly on my workstation if someone wants to quickly test this idea out. |
… text symbols had been slightly darker and more bold (from a chrome update I suspect) causing the pixelmatcher to fail. This now passes locally on my macOS.
…ode-fetch-and-puppeteer-2.6.9
…ey can be reconstructed to PNGs.
…-puppeteer-2.6.9' of github.com:quantumlib/cirq into dependabot/npm_and_yarn/cirq-web/cirq_ts/node-fetch-and-puppeteer-2.6.9
|
Updated the expected images so now the tests are passing. Cleaning up the commits so we can merge. |
|
Looks great, thank you for taking care of this! |
dependabot
bot
deleted the
dependabot/npm_and_yarn/cirq-web/cirq_ts/node-fetch-and-puppeteer-2.6.9
branch
|
Thank you so much @senecameeks |
Bumps node-fetch to 2.6.9 and updates ancestor dependency puppeteer. These dependencies need to be updated together.
Updates
node-fetchfrom 2.6.1 to 2.6.9Release notes
Sourced from node-fetch's releases.
Commits
70f592dfix: "global is not defined" (#1704)0f1ebb0Prevent error when response is null (#1699)6e9464dci(release): install dependenciesdd2a0baci(release): install dependencies49bef02ci(release): use latest Node LTSce37bcdci(semantic-release): config1768eaaci(release): initial version8bb6e31fix: prevent hoisting of the undefinedglobalvariable inbrowser.js(#1534)e218f8dAdd missing changelog entries. (#1613)fddad0efix(headers): don't forward secure headers on protocol change (#1605)Maintainer changes
This version was pushed to npm by node-fetch-bot, a new releaser for node-fetch since your current version.
Updates
puppeteerfrom 10.0.0 to 19.6.3Release notes
Sourced from puppeteer's releases.
... (truncated)
Commits
1dd7bbechore: release main (#9606)e16cbc6fix: restore WaitTask terminate condition (#9612)40068a7docs: fix typo in docs visible on main page (#9607)2457597docs: add codespaces button to contribution guide (#9594)aa1d153chore: Update build dependencies (#9600)390685bfix: ignore not found contexts for console messages (#9595)6f094d2chore: release main (#9601)050a7b0fix: atomically get Puppeteer utilities (#9597)90ef879chore: Add --no-suggestion to custom test runner (#9598)c5068eachore(deps): Bump@angular-devkit/architectfrom 0.1501.2 to 0.1501.3 (#9596)Maintainer changes
This version was pushed to npm by google-wombot, a new releaser for puppeteer since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.