Reducing some code by cleaning up some logic #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…around in circuit.py
viathor
requested changes
Feb 12, 2023
cirq-core/cirq/circuits/circuit.py
Outdated
| active.remove(q) | ||
| elif q in active: | ||
| end_frontier[q] = cur_moment | ||
| active.remove(q) |
There was a problem hiding this comment.
This is shorter, but tests the condition on each iteration. I think the previous code is slightly better.
There was a problem hiding this comment.
makes sense to me! pushed.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* reducing some indenting and amount of reading by changing some logic around in circuit.py * reverting change per code review --------- Co-authored-by: Adam Zalcman <40255865+viathor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through, I noticed some things could be combined to reduce reading and indentation.