Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Obsolete json files #6071

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Removing Obsolete json files #6071

merged 1 commit into from
Apr 21, 2023

Conversation

dstrain115
Copy link
Collaborator

  • These json files are not actually testing anything, since the code currently just returns a string not a device, and returns a warning.
  • This warning causes some extra unneeded noise when running tests.

@dstrain115
Removing Obsolete json files
fc0dac7 
- These json files are not actually testing anything, since
the code currently just returns a string not a device, and returns
a warning.
- This warning causes some extra unneeded noise when running tests.
@dstrain115 dstrain115 requested review from wcourtney, a team, vtomole, cduck and verult as code owners April 20, 2023 22:13
@CirqBot CirqBot added the size: XL lines changed >1000 label Apr 20, 2023
pavoljuhas
pavoljuhas approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just curious - how did you test what files are unused?

@dstrain115
Copy link
Collaborator Author

Just curious - how did you test what files are unused?

I just saw all the annoying deprecations and it made me annoyed enough to change it.

@dstrain115 dstrain115 merged commit 66ae2bc into quantumlib:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

Assignees
No one assigned
Labels
size: XL lines changed >1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @pavoljuhas @CirqBot