-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image links #6085
Fix image links #6085
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs/build/circuits.ipynb
Outdated
@@ -97,7 +103,7 @@ | |||
"id": "77zB_UqkAwCR" | |||
}, | |||
"source": [ | |||
"![Circuits and Moments](/cirq/images/CircuitMomentOperation.png)" | |||
"![Circuits and Moments](https://github.com/quantumlib/Cirq/blob/master/docs/images/CircuitMomentOperation.png)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace (here and below) with a relative link, e.g., (../images/CircuitMomentOperation.png)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yinghui-hu for your suggestion.
The https://quantumai.google website already has these files under the cirq/images path.
It is preferable to use those rather than external files from github.com which may be less optimal for serving static files.
The relative paths of images under https://quantumai.google/cirq/... and https://github.com/quantumlib/Cirq/tree/master/docs/... are the same,
so both cases on GitHub and web can be satisfied by using relative paths.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thanks for the review, Pavol! |
Current links work on https://quantumai.google/ but not on Colab or GitHub webpage