Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image links #6085

Merged
merged 6 commits into from
May 8, 2023
Merged

Fix image links #6085

merged 6 commits into from
May 8, 2023

Conversation

yinghui-hu
Copy link
Contributor

Current links work on https://quantumai.google/ but not on Colab or GitHub webpage

@yinghui-hu yinghui-hu requested review from HGSilveri, a team, vtomole and cduck as code owners April 28, 2023 05:18
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 6, 2023
@@ -97,7 +103,7 @@
"id": "77zB_UqkAwCR"
},
"source": [
"![Circuits and Moments](/cirq/images/CircuitMomentOperation.png)"
"![Circuits and Moments](https://github.com/quantumlib/Cirq/blob/master/docs/images/CircuitMomentOperation.png)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace (here and below) with a relative link, e.g., (../images/CircuitMomentOperation.png)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yinghui-hu for your suggestion.

The https://quantumai.google website already has these files under the cirq/images path.
It is preferable to use those rather than external files from github.com which may be less optimal for serving static files.

The relative paths of images under https://quantumai.google/cirq/... and https://github.com/quantumlib/Cirq/tree/master/docs/... are the same,
so both cases on GitHub and web can be satisfied by using relative paths.

@yinghui-hu
Copy link
Contributor Author

Thank you @yinghui-hu for your suggestion.

The https://quantumai.google website already has these files under the cirq/images path. It is preferable to use those rather than external files from github.com which may be less optimal for serving static files.

The relative paths of images under https://quantumai.google/cirq/... and https://github.com/quantumlib/Cirq/tree/master/docs/... are the same, so both cases on GitHub and web can be satisfied by using relative paths.

Done

@yinghui-hu yinghui-hu requested a review from pavoljuhas May 8, 2023 05:07
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pavoljuhas pavoljuhas enabled auto-merge (squash) May 8, 2023 20:47
@pavoljuhas pavoljuhas merged commit f2cd706 into quantumlib:master May 8, 2023
@yinghui-hu
Copy link
Contributor Author

Thanks for the review, Pavol!

@yinghui-hu yinghui-hu deleted the fix_image_links branch May 9, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants