Fix coverage exclusion syntax #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6241 +/- ##
==========================================
+ Coverage 97.38% 97.60% +0.22%
==========================================
Files 1116 1116
Lines 96110 95772 -338
==========================================
- Hits 93594 93480 -114
+ Misses 2516 2292 -224
☔ View full report in Codecov by Sentry. |
Use `# pragma: no cover` instead of `coverage: ignore`. The pragma format is understood by coverage and codecov.
Use `# pragma: no cover`.
pavoljuhas
force-pushed
the
fix-coverage-exclusion
branch
from
0a4c5da to
81ecbd5
Compare
* must be either on the affected line or at the preceding block * remove no-cover comments for code that is covered * remove unnecessary no-cover duplication
pavoljuhas
requested review from
vtomole,
cduck,
a team,
mrwojtek,
dabacon,
ColemanCollins,
nakardo,
gmauricio,
wcourtney and
verult
as code owners
tanujkhattar
approved these changes
Aug 18, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* switch to standard opt-out comments for code exclusion from coverage * fix placement of `# pragma: no cover` markup comments, so they are either on the affected line or at the preceding block * remove no-cover comments for code that is covered * remove redundant no-cover comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# pragma: no covermarkup comments,so they are either on the affected line or at the preceding block