add back add/remove_qubit to density matrix sim state #6259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6081.
add/remove_qubit()
was added in #6108 and removed in #6127. I've added back the functions and updatedremove_qubit()
toself.factor()
inplace to make the test (simulation_state_test.test_delegating_gate_channel()
) pass.The test was failing because the final density matrices were different for the control and test circuit. The
simulate(test_circuit).final_density_matrix.shape
was (2, 2, 2, 2) whilesimulate(control_circuit).final_density_matrix.shape
was (2, 2). My guess was that the adding qubit was working fine butremove_qubit()
was not able to remove the qubit. After debugging, I found that remove qubit was also working fine butself.factor()
was not being done inplace and the density matrix was not getting updated during the removal of the qubit.