-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make device parameter units/idx optional #6264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Aug 28, 2023
- Currently, the device parameters are picking up zero as the index and failing.
- Need to make them optional so we can set this to None when it is not an array index.
- Yay for proto3!
- Currently, the device parameters are picking up zero as the index and failing. - Need to make them optional so we can set this to None when it is not an array index. - Yay for proto3!
dstrain115
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
August 28, 2023 17:08
pavoljuhas
approved these changes
Aug 28, 2023
dstrain115
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Aug 28, 2023
CirqBot
added
the
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
label
Aug 28, 2023
Automerge cancelled: A required status check is not present. Missing statuses: ['Typescript tests coverage'] |
CirqBot
removed
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
labels
Aug 28, 2023
maffoo
approved these changes
Aug 28, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6264 +/- ##
==========================================
- Coverage 97.60% 97.60% -0.01%
==========================================
Files 1116 1116
Lines 95848 95912 +64
==========================================
+ Hits 93556 93615 +59
- Misses 2292 2297 +5
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.