Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up parameter resolution for cirq.Duration #6270

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Speed up parameter resolution for cirq.Duration #6270

merged 2 commits into from
Aug 30, 2023

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented Aug 29, 2023 •
edited
Loading

Fixes #6269
cc #6097

@tanujkhattar tanujkhattar requested review from vtomole, cduck and a team as code owners August 29, 2023 22:10
@CirqBot CirqBot added the size: M 50< lines changed <250 label Aug 29, 2023
@tanujkhattar tanujkhattar added area/parameters parameter resolution, parameterized gates, operations area/performance labels Aug 29, 2023
@tanujkhattar tanujkhattar mentioned this pull request Aug 29, 2023
Closed
andbe91
andbe91 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@andbe91 andbe91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, thanks for fixing!

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.27% 🎉

Comparison is base (83609eb) 97.60% compared to head (b171bd4) 97.87%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6270      +/-   ##
==========================================
+ Coverage   97.60%   97.87%   +0.27%     
==========================================
  Files        1116     1106      -10     
  Lines       95912    95610     -302     
==========================================
- Hits        93619    93583      -36     
+ Misses       2293     2027     -266
Files Changed Coverage Δ
cirq-core/cirq/circuits/circuit.py 98.43% <100.00%> (+<0.01%) ⬆️
cirq-core/cirq/circuits/frozen_circuit.py 99.26% <100.00%> (+0.25%) ⬆️
cirq-core/cirq/circuits/frozen_circuit_test.py 100.00% <100.00%> (ø)
cirq-core/cirq/value/duration.py 98.80% <100.00%> (+0.15%) ⬆️
cirq-core/cirq/value/duration_test.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar merged commit b28bfce into quantumlib:master Aug 30, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Speed up parameter resolution for cirq.Duration (quantumlib#6270)
134b8d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andbe91 andbe91 andbe91 approved these changes

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
area/parameters parameter resolution, parameterized gates, operations area/performance size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resolve_parameters is slow for cirq.Duration
4 participants
@tanujkhattar @pavoljuhas @andbe91 @CirqBot