Add bitsize field to Cirq-FT Registers
#6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested review from
vtomole,
cduck and
a team
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tanujkhattar
added
the
BREAKING CHANGE
tanujkhattar
force-pushed
the
registers_bitsize
branch
from
fb3b695 to
d936fc7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6286 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 1104 1104
Lines 95854 95863 +9
=======================================
+ Hits 93831 93840 +9
Misses 2023 2023
☔ View full report in Codecov by Sentry. |
mpharrigan
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the
bitsizefield to Cirq-FT registers. This brings the Cirq-FT registers another step closer to Qualtran registers and makes the interop easier.This PR follows a brute force approach where the special meaning of
bitsizeis lost. In general, a qubit register withbitsize=Kshould behave like a2 ** Kdimension Qudit, instead of a K-qubit register. However, Cirq currently does not provide any way to express decomposition of gates acting on qudits in terms of other "simpler" gates that act on individual qubits. In Qualtran, this is expressed usingSplitandJoinoperations, but Cirq does not have an analogous concept.In future, we can consider extending the Cirq infrastructure to support gates acting on Qudits with decompositions that manipulate the 2 dimensional subspaces corresponding to individual qubits that can be used to make up the qudit register. But it's out of scope for this PR.