-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry sweep documentation to cirq_google #6291
Conversation
dstrain115
commented
Sep 18, 2023
- Add some simple documentation on how to use registry sweeps to cirq_google's device page (currently public but not linked to from table of contents)
- Add some simple documentation on how to use registry sweeps to cirq_google's device page (currently public but not linked to from table of contents)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6291 +/- ##
==========================================
- Coverage 97.88% 97.88% -0.01%
==========================================
Files 1104 1104
Lines 95854 95854
==========================================
- Hits 93831 93830 -1
- Misses 2023 2024 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we can fix a few typos in the document, please see the attached patch.
typos-in-google-devices.md.patch.txt
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
…irq-1 into registry_sweep_docs
@pavoljuhas Is there some issue with your CLA or github registration? It's having a problem since I committed your suggestions. |
AFAICT, I should be all configured for the CLA check. The problem seems in commits 1a76baf, ee440ab which have |