Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry sweep documentation to cirq_google #6291

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

dstrain115
Copy link
Collaborator

  • Add some simple documentation on how to use registry sweeps to cirq_google's device page (currently public but not linked to from table of contents)

- Add some simple documentation on how to use registry sweeps
to cirq_google's device page (currently public but not linked to from
table of contents)
@CirqBot CirqBot added the size: S 10< lines changed <50 label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (d805d82) 97.88% compared to head (84f49ff) 97.88%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6291      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files        1104     1104              
  Lines       95854    95854              
==========================================
- Hits        93831    93830       -1     
- Misses       2023     2024       +1     
Files Changed Coverage Δ
cirq-core/cirq/ops/common_channels.py 99.74% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/google/devices.md Outdated Show resolved Hide resolved
docs/google/devices.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can fix a few typos in the document, please see the attached patch.
typos-in-google-devices.md.patch.txt

@dstrain115
Copy link
Collaborator Author

@pavoljuhas Is there some issue with your CLA or github registration? It's having a problem since I committed your suggestions.

@pavoljuhas
Copy link
Collaborator

@pavoljuhas Is there some issue with your CLA or github registration? It's having a problem since I committed your suggestions.

AFAICT, I should be all configured for the CLA check. The problem seems in commits 1a76baf, ee440ab which have Co-authored-by: ... note in the commit message. I have requested CLA override which seems to clear the check here.

@dstrain115 dstrain115 enabled auto-merge (squash) September 20, 2023 01:56
@dstrain115 dstrain115 merged commit 188bb94 into quantumlib:master Sep 20, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants