Move GreedyQubitManager from Cirq-FT to Cirq-Core
#6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
added
BREAKING CHANGE
mpharrigan
reviewed
Oct 6, 2023
Comment on lines
+52
to
+53
| self._used_qubits: Set['cirq.Qid'] = set() | ||
| self._free_qubits: List['cirq.Qid'] = [] |
There was a problem hiding this comment.
let the record reflect that I tried to actually verify that this is just a move but you've changed a few things :p including quoting the types now
There was a problem hiding this comment.
Quoting the types was necessary because earlier, in Cirq-FT, we could just do import cirq but now we either need to import the submodules or put import cirq under if TYPE_CHECKING and quote the types.
This should be the only change, I haven't made any logic changes as part of the move.
mpharrigan
approved these changes
Oct 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
- Coverage 97.89% 97.89% -0.01%
==========================================
Files 1104 1106 +2
Lines 96134 96152 +18
==========================================
+ Hits 94113 94130 +17
- Misses 2021 2022 +1
☔ View full report in Codecov by Sentry. |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Move GreedyQubitManager from Cirq-FT to Cirq-Core * Mark Cirq-FT qubit manager as deprecated * Fix tests * Fix coverage test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Cirq-FT and Qualtran integration.