-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 2q prep for iswap instead of sqrt_iswap #6314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dripto
changed the title
okay now _this_ adds the iswap stuff
Adds 2q prep for iswap instead of sqrt_iswap
Oct 12, 2023
Please add tests and update PR description. |
cirq-core/cirq/transformers/analytical_decompositions/two_qubit_state_preparation.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/transformers/analytical_decompositions/two_qubit_state_preparation.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6314 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 1106 1106
Lines 96157 96180 +23
=======================================
+ Hits 94135 94158 +23
Misses 2022 2022
☔ View full report in Codecov by Sentry. |
tanujkhattar
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a version of the 'prep_two_qubit_state' methods but for a full iswap instead of a sqrt_iswap