Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 2q prep for iswap instead of sqrt_iswap #6314

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

Dripto
Copy link
Contributor

@Dripto Dripto commented Oct 12, 2023

this PR adds a version of the 'prep_two_qubit_state' methods but for a full iswap instead of a sqrt_iswap

@Dripto Dripto requested review from vtomole, cduck and a team as code owners October 12, 2023 18:53
@CirqBot CirqBot added the size: S 10< lines changed <50 label Oct 12, 2023
@Dripto Dripto changed the title okay now _this_ adds the iswap stuff Adds 2q prep for iswap instead of sqrt_iswap Oct 12, 2023
@tanujkhattar
Copy link
Collaborator

Please add tests and update PR description.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a98fc61) 97.89% compared to head (8256f11) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6314   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files        1106     1106           
  Lines       96157    96180   +23     
=======================================
+ Hits        94135    94158   +23     
  Misses       2022     2022           
Files Coverage Δ
cirq-core/cirq/__init__.py 100.00% <ø> (ø)
cirq-core/cirq/transformers/__init__.py 100.00% <ø> (ø)
...transformers/analytical_decompositions/__init__.py 100.00% <ø> (ø)
...ical_decompositions/two_qubit_state_preparation.py 97.95% <100.00%> (+0.59%) ⬆️
...decompositions/two_qubit_state_preparation_test.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar merged commit 105d975 into quantumlib:master Oct 13, 2023
35 checks passed
@Dripto Dripto deleted the u/dripto/iswap-prep branch October 13, 2023 19:32
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants