Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests without affecting browser session #6333

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Run unit tests without affecting browser session #6333

merged 2 commits into from
Nov 1, 2023

Conversation

pavoljuhas
Copy link
Collaborator

Exercise the open_in_browser argument in the
test_generate_html_file_with_browser test, but
do not open a new tab or steal UI focus for the browser.

@pavoljuhas
Run unit tests without affecting user browser session
e0ef2d6 
Exercise the `open_in_browser` argument from the
test_generate_html_file_with_browser test, but do
not affect the actual browser session.
@CirqBot CirqBot added the Size: XS <10 lines changed label Oct 30, 2023
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners October 30, 2023 21:50
@pavoljuhas pavoljuhas requested a review from maffoo October 30, 2023 21:50
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fec68ae) 97.83% compared to head (e0ef2d6) 97.83%.

❗ Current head e0ef2d6 differs from pull request most recent head e49b003. Consider uploading reports for the commit e49b003 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6333      +/-   ##
==========================================
- Coverage   97.83%   97.83%   -0.01%     
==========================================
  Files        1108     1108              
  Lines       96266    96206      -60     
==========================================
- Hits        94184    94124      -60     
  Misses       2082     2082
Files Coverage Δ
cirq-web/cirq_web/widget_test.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar enabled auto-merge (squash) November 1, 2023 17:13
@tanujkhattar tanujkhattar merged commit 5485227 into quantumlib:master Nov 1, 2023
33 checks passed
@pavoljuhas pavoljuhas deleted the no-new-browser-tab-from-tests branch November 1, 2023 17:34
@mhucka mhucka mentioned this pull request Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavoljuhas @tanujkhattar @CirqBot