Increase coverage of clifford protocols to parity_gates #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
vtomole,
cduck and
a team
as code owners
pavoljuhas
reviewed
Nov 10, 2023
cirq-core/cirq/ops/parity_gates.py
Outdated
Comment on lines
298
to
299
| ).on(*qubits) | ||
| ] + clifford_gate.SingleQubitCliffordGate.Z_sqrt.on_each(*qubits) |
There was a problem hiding this comment.
NIT - for the sake of symmetry with XX and YY pow gates
Suggested change
| ).on(*qubits) | |
| ] + clifford_gate.SingleQubitCliffordGate.Z_sqrt.on_each(*qubits) | |
| ).on(*qubits), | |
| clifford_gate.SingleQubitCliffordGate.Z_sqrt.on_each(*qubits), | |
| ] |
pavoljuhas
reviewed
Nov 10, 2023
pavoljuhas
reviewed
Nov 10, 2023
pavoljuhas
reviewed
Nov 10, 2023
pavoljuhas
approved these changes
Nov 10, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6338 +/- ##
=======================================
Coverage 97.83% 97.84%
=======================================
Files 1108 1108
Lines 96372 96398 +26
=======================================
+ Hits 94285 94317 +32
+ Misses 2087 2081 -6
☔ View full report in Codecov by Sentry. |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5906 (comment)