-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update start.ipynb #6342
Update start.ipynb #6342
Conversation
Update the start notebook with the new start notebook that details how to run against our hardware. Notably, only people with access can run circuits against our hardware.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6342 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 1110 1110
Lines 96597 96656 +59
==========================================
+ Hits 94516 94572 +56
- Misses 2081 2084 +3 ☔ View full report in Codecov by Sentry. |
Added a few quick-to-resolve typo and link fixes. Otherwise LGTM to publish before resolving other issues in go/quacstart-feedback so that we have something posted. |
attach --pre flag to cirq install for stable version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Put in default value for processor_id
add Black as default. This _shouldn't_ run against actual hardware since a valid project_id is never specified. A valid `processor_id` however is needed to pass the CI.
populate default project_id
make default processor_id an empty string now that `virtual=True` is set
add back processor_id so it matches current merged version
rm `cirq --pre` install
delete overriding instance of `engine`
Add back original fix to known issue nteract/papermill#519
resolve nit
@@ -1,478 +1,532 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another text block followed by code.
Text: "Among these best practices, we will highlight two important ones.
First, if your circuit uses more than one qubit, you can map the circuit onto the grid of the quantum processor in a way that accounts for its topology. You can do this as follows:
Code:
device_graph = device.metadata.nx_graph router = cirq.RouteCQC(device_graph) hw_circuit = router(circuit) print(hw_circuit)
Second, if your quantum processor is calibrated to do a specific set of gates, you will need to transform your circuit into that gateset. For example, for a CZ gateset, you can do the following."
Code:
gateset = cirq.CZTargetGateset(allow_partial_czs=True) hw_circuit = cirq.optimize_for_target_gateset(hw_circuit, gateset=gateset) print(hw_circuit)
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to that text above: Other gatesets and considerations are included in the best practices guide
with same hyperlink as Will Courtney's above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up with another PR to add this improvement. Up to this point I've been editing the codelab's raw json file directly (this was easiest for the initial quick changes), but adding another text/code block this way will likely cause errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The followup PR is #6346
reduce wordiness
…eset. A follow up from quantumlib#6342
Update the start tutorial with a new notebook that details how to run circuits using our hardware. Note, only some people will have access to use our physical devices.