-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dummy from cirq-core #6356
Remove dummy from cirq-core #6356
Conversation
dstrain115
commented
Nov 21, 2023
- Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.
- Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6356 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 1110 1110
Lines 96696 96696
==========================================
- Hits 94612 94608 -4
- Misses 2084 2088 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. There are however still some dummy-named classes in test modules:
$ git grep -i '(class|def) .*dummy' cirq-core
cirq-core/cirq/circuits/qasm_output_test.py:251: class DummyOperation(cirq.Operation):
...
I can help with those if needed.
@pavoljuhas Added a bunch more references, PTAL, thanks! |
Follow up to quantumlib#6356. Replace non-inclusive terminology.
Follow up to #6356. Replace non-inclusive terminology.
* Remove dummy from cirq-core - Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.