Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at least one output to the start notebook #6360

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

senecameeks
Copy link
Collaborator

The tensorflow import tool will skip trying to run any notebook that has any output, and instead publishes the notebook as is to the website. This includes a print of a simple circuit to get around the import tool.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@senecameeks
Copy link
Collaborator Author

To clarify-- currently the import tool tries to execute the notebook since there is no output and fails (the engine api isn't enabled to run for the tensorflow-testing project). When it fails, the notebook isn't published to the website
If there is any output included (what the PR does and what we want), the import tool will skip trying to execute the notebook and publish it as is.

Copy link
Collaborator

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@senecameeks
Copy link
Collaborator Author

cc: @MichaelBroughton , my comment above might be helpful for future attempts to import notebooks to the website.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5b3b74) 97.84% compared to head (21f6d1c) 97.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6360   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files        1110     1110           
  Lines       96690    96690           
=======================================
  Hits        94606    94606           
  Misses       2084     2084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks merged commit 7f47e13 into quantumlib:master Nov 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants