Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote problematic terminology from test #6368

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remote problematic terminology from test #6368

merged 1 commit into from
Dec 1, 2023

Conversation

dstrain115
Copy link
Collaborator

  • "Dude, blacklist is not the preferred nomenclature here."

@dstrain115
Remote problematic terminology from test
2cc51f0 
- "Dude, blacklist is not the preferred nomenclature here."
@dstrain115 dstrain115 requested review from vtomole, cduck and a team as code owners December 1, 2023 14:26
@dstrain115 dstrain115 requested a review from viathor December 1, 2023 14:26
viathor
viathor approved these changes Dec 1, 2023
View reviewed changes
cirq-core/cirq/protocols/json_serialization_test.py
@@ -237,7 +237,7 @@ def test_not_yet_serializable_no_superfluous(mod_spec: ModuleJsonTestSpec):


@pytest.mark.parametrize('mod_spec', MODULE_TEST_SPECS, ids=repr)
def test_mutually_exclusive_blacklist(mod_spec: ModuleJsonTestSpec):
def test_mutually_exclusive_lists(mod_spec: ModuleJsonTestSpec):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: blocklist and passlist are self-explanatory alternatives.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I didn't think that these were necessary. Should not serialize and not yet serialize I guess are block lists, but the term didn't really seem to fit.

@dstrain115 dstrain115 merged commit 9b65f68 into quantumlib:main Dec 1, 2023
33 checks passed
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dstrain115
Remote problematic terminology from test (quantumlib#6368)
ff6555a 
- "Dude, blacklist is not the preferred nomenclature here."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstrain115 @viathor