Check identity first when comparing circuits #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6375 +/- ##
========================================
Coverage 97.80% 97.81%
========================================
Files 1111 1111
Lines 96877 97037 +160
========================================
+ Hits 94754 94914 +160
Misses 2123 2123 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Dec 18, 2023
maffoo
changed the title
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add identity check to short-circuit exact and approximate equality checks on
cirq.AbstractCircuitand subclasses. Also change the implementation of__eq__to avoid creating new tuples of moments; instead we check the length and then zip over the moments.