-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize clifford benchmark circuit creation for a total 94.5% speedup #6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
mrwojtek,
vtomole,
cduck and
a team
as code owners
January 8, 2024 20:14
maffoo
reviewed
Jan 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6401 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97054 97088 +34
=======================================
+ Hits 94931 94965 +34
Misses 2123 2123 ☔ View full report in Codecov by Sentry. |
maffoo
approved these changes
Jan 8, 2024
Nice work! |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
quantumlib#6401) This is a followup to quantumlib#6392 and reduces circuit creation time (for 1000 cliffords and 50 qubits) to 0.213s from the original 3.886s (94.5% speedup) and the 2.148s (90% speedup) following quantumlib#6392 ``` In [3]: import cirq.experiments.qubit_characterizations as ceq ...: import cirq ...: import time ...: import numpy as np ...: ...: num_cliffords = 1000 ...: qubits = cirq.LineQubit.range(50) ...: ...: cliffords = ceq._single_qubit_cliffords() ...: c1 = cliffords.c1_in_xy ...: t1 = time.time() ...: seq = ceq._create_parallel_rb_circuit(qubits, num_cliffords, c1) ...: t2 = time.time() ...: print(f'{t2-t1} s') 0.2055680751800537 s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #6392 and reduces circuit creation time (for 1000 cliffords and 50 qubits) to 0.213s from the original 3.886s (94.5% speedup) and the 2.148s (90% speedup) following #6392