Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx version #6415

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Update sphinx version #6415

merged 5 commits into from
Jan 17, 2024

Conversation

smburdick
Copy link
Contributor

Addressing #6400

@smburdick smburdick requested review from vtomole, cduck and a team as code owners January 16, 2024 20:28
@smburdick smburdick requested a review from viathor January 16, 2024 20:28
@smburdick smburdick marked this pull request as draft January 16, 2024 20:28
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ae5bbb) 97.81% compared to head (152d47e) 97.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6415   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files        1111     1111           
  Lines       97078    97078           
=======================================
  Hits        94957    94957           
  Misses       2121     2121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smburdick smburdick marked this pull request as ready for review January 16, 2024 20:47
@smburdick
Copy link
Contributor Author

@pavoljuhas following up, can't add you as a reviewer.

smburdick and others added 3 commits January 16, 2024 13:12
Remove package pinning workarounds introduced for quantumlib#6400.
Also remove an old pinning of the Jinja2 package which
is unlikely to be still needed.
@pavoljuhas pavoljuhas self-requested a review January 17, 2024 00:33
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smburdick - I have added a few clean-up tweaks at my branch amend-pr-6415.

Please update this PR using

git pull https://github.com/pavoljuhas/Cirq.git amend-pr-6415

and it will be good to go.

Thank you for a quick response!

@smburdick smburdick requested a review from pavoljuhas January 17, 2024 00:53
@pavoljuhas pavoljuhas enabled auto-merge (squash) January 17, 2024 00:59
@pavoljuhas pavoljuhas merged commit 9c451a2 into quantumlib:main Jan 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants