-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin quimb and numba versions to fix CI #6438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I am getting a reproducible decimal.DivisionByZero exception after the quimb update -
output======================================================= FAILURES =======================================================
../../../../../../../../../tmp/t39/lib/python3.9/site-packages/cotengra/hyperoptimizers/hyper.py:34 -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html |
@pavoljuhas yea same. looks like the latest quimb breaks the tests in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6438 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1111
Lines 97143 97143
==========================================
- Hits 95022 95017 -5
- Misses 2121 2126 +5 ☔ View full report in Codecov by Sentry. |
* Enable Contract-a-Grid-Circuit.ipynb in notebook tests, but test it only with the pre-release Cirq. The notebook requires a pinned version of quimb from quantumlib#6438 otherwise the tensor_expectation_value() call in the last-cell causes out-of-memory error. Fixes quantumlib#6088
fixes #6437
older versions of quimb use a numbda decorator that no longer exists. the recent release of quimb fixes that https://github.com/jcmgray/quimb/blob/0f9db3f7b81e50375b5001296bfc2b767a7e557d/docs/changelog.md however it breaks tests in
/contrib/quimb
so will pin the versions for now.