-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - update GitHub actions to node20 #6450
CI - update GitHub actions to node20 #6450
Conversation
NTS - submit for review once all workflows are checked for old actions. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6450 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1115 +4
Lines 97198 97337 +139
==========================================
+ Hits 95078 95208 +130
- Misses 2120 2129 +9 ☔ View full report in Codecov by Sentry. |
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days' | ||
days-before-stale: 30 | ||
days-before-close: 30 | ||
close-issue-message: 'Issue closed due to inactivity.' | ||
stale-issue-label: 'triage/stale' | ||
exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there a diff here? as far as I can see there are no changes to this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vim by default fixes up missing newline at the end of file. Proper text files should end in a newline,
otherwise cat f1.txt f2.txt
will have strange result.
$ git diff -U0 HEAD^2
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index c840eb08..dd7cb263 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -10 +10 @@ jobs:
- - uses: actions/stale@v3
+ - uses: actions/stale@v9
@@ -18 +18 @@ jobs:
- exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
\ No newline at end of file
+ exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
Bump up to actions/stale@v9 compatible with node20 per
https://github.com/actions/stale/releases/tag/v9.0.0
Related to #6445