Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - update GitHub actions to node20 #6450

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

pavoljuhas
Copy link
Collaborator

Bump up to actions/stale@v9 compatible with node20 per
https://github.com/actions/stale/releases/tag/v9.0.0

Related to #6445

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 8, 2024
@pavoljuhas
Copy link
Collaborator Author

NTS - submit for review once all workflows are checked for old actions.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f2c6f3c) 97.81% compared to head (58b9e3b) 97.81%.
Report is 8 commits behind head on main.

❗ Current head 58b9e3b differs from pull request most recent head b46213a. Consider uploading reports for the commit b46213a to get more accurate results

Files Patch % Lines
cirq-core/cirq/experiments/two_qubit_xeb.py 98.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   97.81%   97.81%   -0.01%     
==========================================
  Files        1111     1115       +4     
  Lines       97198    97337     +139     
==========================================
+ Hits        95078    95208     +130     
- Misses       2120     2129       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review February 12, 2024 21:42
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners February 12, 2024 21:42
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days'
days-before-stale: 30
days-before-close: 30
close-issue-message: 'Issue closed due to inactivity.'
stale-issue-label: 'triage/stale'
exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a diff here? as far as I can see there are no changes to this line.

Copy link
Collaborator Author

@pavoljuhas pavoljuhas Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim by default fixes up missing newline at the end of file. Proper text files should end in a newline,
otherwise cat f1.txt f2.txt will have strange result.

$ git diff -U0 HEAD^2
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index c840eb08..dd7cb263 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -10 +10 @@ jobs:
-    - uses: actions/stale@v3
+    - uses: actions/stale@v9
@@ -18 +18 @@ jobs:
-        exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
\ No newline at end of file
+        exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'

@pavoljuhas pavoljuhas enabled auto-merge (squash) February 12, 2024 22:12
@pavoljuhas pavoljuhas merged commit c3de706 into quantumlib:main Feb 12, 2024
32 checks passed
@pavoljuhas pavoljuhas deleted the ci-update-actions-to-node20 branch February 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants