[Refactoring]: split devices.noise_utils into qis.noise_utils and devices.noise_utils
#6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cirq/qis/noise_utils_test.py
…/cirq/qis/noise_utils_test.py
…/cirq/qis/noise_utils_test.py
…/cirq/qis/noise_utils_test.py
…/qis/noise_utils.py
…/qis/noise_utils.py
…/qis/noise_utils.py
…/qis/noise_utils.py
NoureldinYosri
changed the title
devices.noise_utils into qis.noise_utils and devices.noise_utils
NoureldinYosri
added
the
BREAKING CHANGE
NoureldinYosri
requested review from
vtomole,
cduck and
a team
as code owners
NoureldinYosri
force-pushed
the
noise_utils3
branch
from
b42bf59 to
b91f1fd
Compare
eliottrosenberg
approved these changes
Feb 8, 2024
| @@ -0,0 +1,123 @@ | |||
| # Copyright 2021 The Cirq Developers | |||
There was a problem hiding this comment.
Should we update the year?
| @@ -0,0 +1,97 @@ | |||
| # Copyright 2021 The Cirq Developers | |||
There was a problem hiding this comment.
I don't know. I'm not creating new content. it's the same file. @pavoljuhas what do you think?
There was a problem hiding this comment.
I think either way is fine in this case, feel free to leave it as is.
For new module with new code we should use current year.
pavoljuhas
requested changes
Feb 8, 2024
There was a problem hiding this comment.
I added the
BREAKING CHANGElabel because if it will break users of these functions who will have to import the functions from qis rather than devices.
Can you add deprecated proxies to the moved functions at their original modules?
The @deprecated decorator at cirq._compat should help with that.
|
@pavoljuhas ptal |
pavoljuhas
reviewed
Feb 9, 2024
pavoljuhas
approved these changes
Feb 9, 2024
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
… `devices.noise_utils` (quantumlib#6453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the functions in devices.noise_utils do conversion between different errors. these functions are not specific to devices but fall more appropriately under qis.
This change is because these functions will be used in
cirq.experimentsI added the
BREAKING CHANGElabel because if it will break users of these functions who will have to import the functions from qis rather than devices.