Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address NumPy and NotImplemented deprecation warnings #6465

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Address NumPy and NotImplemented deprecation warnings #6465

merged 6 commits into from
Feb 16, 2024

Conversation

pavoljuhas
Copy link
Collaborator

No description provided.

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 14, 2024
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 14, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a40da5) 97.82% compared to head (f6254ff) 97.82%.
Report is 2 commits behind head on main.

❗ Current head f6254ff differs from pull request most recent head dee4217. Consider uploading reports for the commit dee4217 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6465   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1115     1115           
  Lines       97448    97448           
=======================================
  Hits        95327    95327           
  Misses       2121     2121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review February 15, 2024 02:05
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners February 15, 2024 02:05
@pavoljuhas
Copy link
Collaborator Author

Note the CI caught these DeprecationWarning-s at 662aa05 and the fixed code passes at 5a8c13b.

@pavoljuhas pavoljuhas enabled auto-merge (squash) February 16, 2024 23:31
@pavoljuhas pavoljuhas merged commit a4ec796 into quantumlib:main Feb 16, 2024
32 checks passed
@pavoljuhas pavoljuhas deleted the clean-some-deprecations branch February 21, 2024 23:16
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@pavoljuhas
Address NumPy and NotImplemented deprecation warnings (quantumlib#6465)
b74e166 
* Replace deprecated numpy aliases for dtype-s
  `np.int0` --> `np.intp` and `np.uint0` --> `np.uintp`

* Address deprecation warning about NotImplemented used as boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavoljuhas @tanujkhattar @CirqBot