Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change str of ResultDict to print out repeated measurements #6468

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Change str of ResultDict to print out repeated measurements #6468

merged 2 commits into from
Feb 16, 2024

Conversation

dstrain115
Copy link
Collaborator

  • ResultDict will now print out repeated measurements on each line, as opposed to throwing ValueError

Fixes: #6447

@dstrain115
Change str of ResultDict to print out repeated measurements
a5bcf12 
- ResultDict will now print out repeated measurements on each
line, as opposed to throwing ValueError

Fixes: quantumlib#6447
@dstrain115 dstrain115 requested review from vtomole, cduck and a team as code owners February 16, 2024 21:59
@dstrain115 dstrain115 requested a review from viathor February 16, 2024 21:59
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 16, 2024
@dstrain115 dstrain115 enabled auto-merge (squash) February 16, 2024 22:11
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a40da5) 97.82% compared to head (a5bcf12) 97.81%.
Report is 1 commits behind head on main.

❗ Current head a5bcf12 differs from pull request most recent head 159d324. Consider uploading reports for the commit 159d324 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6468      +/-   ##
==========================================
- Coverage   97.82%   97.81%   -0.01%     
==========================================
  Files        1115     1115              
  Lines       97448    97468      +20     
==========================================
+ Hits        95327    95342      +15     
- Misses       2121     2126       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dstrain115 dstrain115 merged commit a8bd9a5 into quantumlib:main Feb 16, 2024
32 checks passed
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dstrain115
Change str of ResultDict to print out repeated measurements (quantuml…
fe2fb2c 
…ib#6468)

- ResultDict will now print out repeated measurements on each
line, as opposed to throwing ValueError

Fixes: quantumlib#6447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't print the ResultDict of an array with 2 values
4 participants
@dstrain115 @pavoljuhas @tanujkhattar @CirqBot