fixed mpmath version to 1.3.0 due to incompatibility #6477
Conversation
There was a problem hiding this comment.
Looks good with a small change.
Please feel free to convert from draft. The main branch currently skips the failing test so the CI should pass for this PR.
Once this PR is in we can re-enable the test, because mpmath pinning will be in effect in the cirq-core pre-release.
cirq-core/requirements.txt
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| duet>=0.2.8 | |||
| matplotlib~=3.0 | |||
| mpmath~=1.3.0 | |||
There was a problem hiding this comment.
Thank you for tracking this down!
I think we can use a less restrictive mpmath spec to be in sync with sympy requirement for mpmath>=0.19.
| mpmath~=1.3.0 | |
| # Temporary fix for https://github.com/sympy/sympy/issues/26273 | |
| # TODO: remove once `pip install --pre sympy` works in a fresh environment | |
| mpmath<=1.3.* |
There was a problem hiding this comment.
@pavoljuhas
Thank you for comment!
I have reflected the comment and confirmed that it passes the test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 1105 1105
Lines 94925 94925
=======================================
Hits 92793 92793
Misses 2132 2132 ☔ View full report in Codecov by Sentry. |
…quantumlib#6477)" This reverts commit e11132e.
…quantumlib#6477)" Not needed after quantumlib#6534 as cirq pre-releases are installed with stable dependencies. This reverts commit e11132e. Related to quantumlib#6475
Version limit on mpmath is unnecessary after quantumlib#6534 because cirq pre-releases are now installed with stable dependencies. This reverts commit e11132e (quantumlib#6477). Related to quantumlib#6475
Version limit on mpmath is unnecessary after quantumlib#6534 because cirq pre-releases are now installed with stable dependencies. This reverts commit e11132e (quantumlib#6477). Related to quantumlib#6475
Dealing with CI pipeline failures following upgrades of incompatible packages. (detail issues: #6475)
The error location is
Dockerfilein line 26. This one downloads the package from PyPI, but my permission do not allow me to update the package. Therefore, I have changed the version ofmpmathin my local environment, and I am hoping that the test will pass.