Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update parallel XEB notebook #6494

Merged
merged 13 commits into from
Mar 15, 2024
Merged

update parallel XEB notebook #6494

merged 13 commits into from
Mar 15, 2024

Conversation

NoureldinYosri
Copy link
Collaborator

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 12, 2024
@NoureldinYosri NoureldinYosri marked this pull request as ready for review March 13, 2024 00:02
@NoureldinYosri NoureldinYosri requested review from mrwojtek, vtomole, cduck and a team as code owners March 13, 2024 00:02
@NoureldinYosri
Copy link
Collaborator Author

@eliottrosenberg I don't know if this is enough or not. how do you think we should modify the notebooks?

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (2700f95) to head (19fc664).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6494   +/-   ##
=======================================
  Coverage   97.75%   97.76%           
=======================================
  Files        1105     1105           
  Lines       95030    95030           
=======================================
+ Hits        92898    92902    +4     
+ Misses       2132     2128    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliottrosenberg
Copy link
Collaborator

@eliottrosenberg I don't know if this is enough or not. how do you think we should modify the notebooks?

I think this is basically sufficient. I added a few small suggestions.

eliottrosenberg
eliottrosenberg reviewed Mar 13, 2024
View reviewed changes
docs/noise/qcvv/parallel_xeb.ipynb
@@ -65,7 +65,7 @@
" import cirq\n",
Copy link
Collaborator

@eliottrosenberg eliottrosenberg Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that it's worth commenting that the default entangling gate in parallel_two_qubit_xeb is CZ even though this example uses sqrt_iswap?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@eliottrosenberg eliottrosenberg self-requested a review March 13, 2024 20:41
eliottrosenberg
eliottrosenberg approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment/question. Otherwise LGTM.

pavoljuhas
pavoljuhas requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for usability, otherwise LGTM.

docs/noise/qcvv/parallel_xeb.ipynb Outdated Show resolved Hide resolved
docs/noise/qcvv/parallel_xeb.ipynb Show resolved Hide resolved
docs/noise/qcvv/parallel_xeb.ipynb Outdated Show resolved Hide resolved
pavoljuhas
pavoljuhas approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) March 15, 2024 19:27
@NoureldinYosri NoureldinYosri merged commit 0f4822b into quantumlib:main Mar 15, 2024
31 checks passed
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@NoureldinYosri @jselig-rigetti
update parallel XEB notebook (quantumlib#6494)
da0f221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliottrosenberg eliottrosenberg eliottrosenberg approved these changes

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@mrwojtek mrwojtek Awaiting requested review from mrwojtek mrwojtek is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoureldinYosri @eliottrosenberg @pavoljuhas @CirqBot