-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display tags by str
instead of repr
in circuit diagrams
#6530
Conversation
@richrines1 - This looks good to me considering the context of the title and considering no issues with refreshing the branch to current. Regarding implementation of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6530 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 1124 1124
Lines 95486 95468 -18
=======================================
- Hits 93376 93359 -17
+ Misses 2110 2109 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a small suggestion to use map for brevity.
As for the _circuit_diagram_info_
- I feel it would be better to add in a separate PR.
Thank you for contributing this!
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
…ib#6530) Use more readable rendering of tagged operations in diagrams. Fixes: quantumlib#6411
…ib#6530) Use more readable rendering of tagged operations in diagrams. Fixes: quantumlib#6411
addresses #6411
as described in this comment it might also be nice to allow tags to define their own
_circuit_diagram_info_
magic method - happy to add this (either here or in a follow up) if this would be preferred