Set maxsize of request queue to Quantum Engine #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6576 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 1124 1124
Lines 95658 95659 +1
=======================================
+ Hits 93549 93550 +1
Misses 2109 2109 ☔ View full report in Codecov by Sentry. |
senecameeks
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
NoureldinYosri
approved these changes
Apr 30, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
* set maxsize for request queue * add max message size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to prevent overwhelming the engine tasks with too many requests.
Setting a maxsize does not reject requests that happen after the queue is full. Instead, when a request is to be put into the queue it will wait until a free slot is available before adding.
We also limit the size of the request messages sent to prevent overloading the server with very large requests.