Fix spurious failure of the check/all script #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: check/format-incremental fails when invoked with an empty string, because it is not a valid git revision. Solution: Use shell array to store the revision in check/all, that way it is not passed as a sub-command argument if unset.
Ensure grep matches `?` as a literal character.
Allow git tags which point to a commit.
Problem: check/mypy passes in the mypy.env.txt environment, but fails on "unnecessary type ignore" in dev.env.txt virtual environment, because it installs IPython with its type information. Solution: Ignore IPython in type checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1063 1063
Lines 91761 91761
=======================================
+ Hits 89755 89759 +4
+ Misses 2006 2002 -4 ☔ View full report in Codecov by Sentry. |
|
@95-martin-orion - can you PTAL? |
95-martin-orion
approved these changes
May 23, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
- Avoid passing an empty string argument to `check/format-incremental` when invoked from `check/all` - Improve validation of the git-revision argument in check scripts by allowing git tags that resolve to a commit - Fix invalid use of `?` in egrep pattern - Make check/mypy pass in the dev.env.txt virtual environment
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
- Avoid passing an empty string argument to `check/format-incremental` when invoked from `check/all` - Improve validation of the git-revision argument in check scripts by allowing git tags that resolve to a commit - Fix invalid use of `?` in egrep pattern - Make check/mypy pass in the dev.env.txt virtual environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid passing an empty string argument to
check/format-incrementalwhen invoked from
check/allImprove validation of the git-revision argument in check scripts by
allowing git tags that resolve to a commit
Fix invalid use of
?in egrep patternMake check/mypy pass in the dev.env.txt virtual environment