Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper text files end with a newline character #6614

Merged
merged 2 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ P1 - I need this no later than the next release (end of quarter)
P2 - we should do it in the next couple of quarters
P3 - I'm not really blocked by it, it is an idea I'd like to discuss / suggestion based on principle

<!-- [optional] additional comment / context -->
<!-- [optional] additional comment / context -->
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/task.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Project task
about: Task to track larger efforts
about: Task to track larger efforts
title: ''
labels: 'kind/task'
assignees: ''
Expand All @@ -16,4 +16,4 @@ assignees: ''
<!-- optional, feel free to remove this section -->
**Related**

Related issues: #abc, #xyz, ...
Related issues: #abc, #xyz, ...
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,4 @@ harassment or threats to anyone's safety, we may take action without notice.

This Code of Conduct is adapted from the Contributor Covenant, version 1.4,
available at
https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
2 changes: 1 addition & 1 deletion benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ You can also pass arguments to the script, which would be forwarded to the `asv
Please refer [Running Benchmarks guide by ASV](https://asv.readthedocs.io/en/stable/using.html#running-benchmarks) for more information.

## Results Database
TODO([#3838](https://github.com/quantumlib/Cirq/issues/3838)): Add details regarding GCP setup.
TODO([#3838](https://github.com/quantumlib/Cirq/issues/3838)): Add details regarding GCP setup.
2 changes: 1 addition & 1 deletion cirq-aqt/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
requests~=2.18
requests~=2.18
2 changes: 1 addition & 1 deletion cirq-google/cirq_google/api/v2/program.proto
Original file line number Diff line number Diff line change
Expand Up @@ -462,4 +462,4 @@ message IdentityGate {

message HPowGate {
FloatArg exponent = 1;
}
}
2 changes: 1 addition & 1 deletion cirq-google/cirq_google/devices/specifications/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ This directory contains snapshots of `DeviceSpecification` proto messages

Files with the suffix `_for_grid_device` are equivalent representations of corresponding proto files
without the suffix, but in the new `DeviceSpecification` format which is parsed into
`cirq_google.GridDevice`.
`cirq_google.GridDevice`.
2 changes: 1 addition & 1 deletion cirq-google/version_policy.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# cirq-google Version Policy

The `cirq-google` directory should abide by Semantic Versioning 2.0.0. In rare cases, we may introduce backward-incompatible changes to the public API in a release with a minor version increment. Such changes will be noted in `CHANGELOG.md` within the directory before the release.
The `cirq-google` directory should abide by Semantic Versioning 2.0.0. In rare cases, we may introduce backward-incompatible changes to the public API in a release with a minor version increment. Such changes will be noted in `CHANGELOG.md` within the directory before the release.
2 changes: 1 addition & 1 deletion cirq-ionq/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
requests~=2.18
requests~=2.18
2 changes: 1 addition & 1 deletion cirq-pasqal/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
requests~=2.18
requests~=2.18
2 changes: 1 addition & 1 deletion cirq-web/cirq_ts/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
build/
**/node_modules
**/dist
**/dist
2 changes: 1 addition & 1 deletion cirq-web/cirq_ts/dist/html/bloch_sphere.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
.addVector(1, 0, 0);
</script>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion cirq-web/cirq_ts/dist/html/circuit.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@
});
</script>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion dev_tools/modules_test_data/mod1/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
req1
req2
req2
2 changes: 1 addition & 1 deletion dev_tools/pr_monitor/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ RUN pip install -r ./dev_tools/pr_monitor/requirements.txt
COPY ./*.py ./dev_tools/

ENV PYTHONPATH=/app
CMD ["python", "dev_tools/pr_monitor.py"]
CMD ["python", "dev_tools/pr_monitor.py"]
2 changes: 1 addition & 1 deletion dev_tools/pr_monitor/cloudbuild-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ steps:
- skaffold
- run
- --force
- -f=dev_tools/pr_monitor/skaffold.yaml
- -f=dev_tools/pr_monitor/skaffold.yaml
2 changes: 1 addition & 1 deletion dev_tools/pr_monitor/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
requests==2.32.0
google-cloud-secret-manager==1.0.0
google-cloud-secret-manager==1.0.0
2 changes: 1 addition & 1 deletion dev_tools/pr_monitor/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ spec:
spec:
containers:
- name: cirq-pr-monitor
image: us-docker.pkg.dev/cirq-infra/cirq/pr_monitor
image: us-docker.pkg.dev/cirq-infra/cirq/pr_monitor
2 changes: 1 addition & 1 deletion dev_tools/requirements/isolated-base.env.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
-r deps/notebook.txt

# for shell_tools
requests
requests
2 changes: 1 addition & 1 deletion dev_tools/requirements/mypy.env.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# compile it with pip-compile dev_tools/requirements/dev.txt

-r deps/cirq-all.txt
-r deps/mypy.txt
-r deps/mypy.txt
2 changes: 1 addition & 1 deletion dev_tools/requirements/no-contrib.env.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
-r deps/cirq-all-no-contrib.txt
-r deps/dev-tools.txt
-r deps/dev-tools.txt
2 changes: 1 addition & 1 deletion dev_tools/requirements/test_data/b.req.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# a comment
b
b
2 changes: 1 addition & 1 deletion dev_tools/requirements/test_data/sub/c.req.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# c is included
# this one has no new line at the end
c
c
2 changes: 1 addition & 1 deletion dev_tools/triage-party/cloudbuild-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ steps:
- skaffold
- run
- --force
- -f=dev_tools/triage-party/skaffold.yaml
- -f=dev_tools/triage-party/skaffold.yaml
2 changes: 1 addition & 1 deletion dev_tools/triage-party/kubernetes/01_ns/namespace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ kind: Namespace
metadata:
name: triage-party
labels:
name: triage-party
name: triage-party
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,4 @@ data:
filters:
- tag: recv
- responded: +7d
- label: "kind/design-issue"
- label: "kind/design-issue"