Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor drop_negligible into an OptimizationPass using batch_remove #695

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Refactor drop_negligible into an OptimizationPass using batch_remove #695

merged 3 commits into from
Jul 17, 2018

Conversation

Strilanc
Copy link
Contributor

No description provided.

@Strilanc Strilanc requested a review from dabacon July 17, 2018 06:48
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 17, 2018
@dabacon
Copy link
Collaborator

dabacon commented Jul 17, 2018

Looks like build is failing?

@Strilanc
Copy link
Contributor Author

Strilanc commented Jul 17, 2018 •
edited
Loading

Ah, some of the tests were checking the point optimization. Will fix. Good job travis-ci!

@Strilanc Strilanc requested a review from cduck July 17, 2018 17:51
cduck
cduck approved these changes Jul 17, 2018
View reviewed changes
Copy link
Collaborator

@cduck cduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strilanc Strilanc merged commit 8750e8c into master Jul 17, 2018
@Strilanc Strilanc deleted the optimize-0 branch July 17, 2018 23:13
@Benjamin-KY Benjamin-KY mentioned this pull request Mar 31, 2023
Open
@kingjay66 kingjay66 mentioned this pull request May 13, 2024
Open
@soloinovator soloinovator mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduck cduck cduck approved these changes

@dabacon dabacon Awaiting requested review from dabacon

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Strilanc @dabacon @cduck @googlebot