Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OpTree with OP_TREE #6960

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Replace OpTree with OP_TREE #6960

merged 3 commits into from
Jan 23, 2025

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Jan 19, 2025

There was a comment in op_tree.py to do this once mypy supports recursive types. The referenced issue python/mypy#731 is now closed, and the suggested replacement seems to work.

image

cc @maffoo

@daxfohl daxfohl requested review from vtomole and a team as code owners January 19, 2025 14:49
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (4206cb1) to head (ac0c202).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6960      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files        1085     1085              
  Lines       94962    94957       -5     
==========================================
- Hits        92952    92947       -5     
  Misses       2010     2010              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dstrain115 dstrain115 requested a review from maffoo January 21, 2025 15:26
@daxfohl daxfohl added this pull request to the merge queue Jan 21, 2025
@daxfohl daxfohl removed this pull request from the merge queue due to a manual request Jan 21, 2025
@daxfohl daxfohl closed this Jan 23, 2025
@daxfohl daxfohl deleted the remove-optree branch January 23, 2025 01:48
@daxfohl daxfohl restored the remove-optree branch January 23, 2025 01:50
@daxfohl daxfohl reopened this Jan 23, 2025
@daxfohl daxfohl enabled auto-merge January 23, 2025 01:51
@daxfohl daxfohl added this pull request to the merge queue Jan 23, 2025
Merged via the queue into quantumlib:main with commit ebbaad6 Jan 23, 2025
37 checks passed
@daxfohl daxfohl deleted the remove-optree branch January 23, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants