-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cirq.testing.assert_circuits_with_terminal_measurements_are_equivalent #700
Conversation
…alent - Use it in eject_z_test and eject_full_w_test Fixes #670
cirq/testing/circuit_compare.py
Outdated
actual: circuits.Circuit, | ||
expected: circuits.Circuit, | ||
atol: float) -> None: | ||
""" Determines if two circuits are equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
cirq/testing/circuit_compare.py
Outdated
|
||
|
||
def _cancel_qubit_phase(m1: np.ndarray, m2: np.ndarray, k: int) -> None: | ||
n = m1.shape[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a comment or doc string just explaining what this is doing, I had to read it a few times to figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes #670