Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cirq.testing.assert_circuits_with_terminal_measurements_are_equivalent #700

Merged
merged 5 commits into from
Jul 17, 2018

Conversation

Strilanc
Copy link
Contributor

  • Use it in eject_z_test and eject_full_w_test

Fixes #670

@Strilanc Strilanc requested review from dabacon and cduck July 17, 2018 09:37
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 17, 2018
actual: circuits.Circuit,
expected: circuits.Circuit,
atol: float) -> None:
""" Determines if two circuits are equivalent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.



def _cancel_qubit_phase(m1: np.ndarray, m2: np.ndarray, k: int) -> None:
n = m1.shape[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a comment or doc string just explaining what this is doing, I had to read it a few times to figure it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 17, 2018
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 17, 2018
@quantumlib quantumlib deleted a comment from CirqBot Jul 17, 2018
@Strilanc Strilanc merged commit 2beb783 into master Jul 17, 2018
@Strilanc Strilanc deleted the optimize-3 branch July 17, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants