Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Use dev pytest version in verification #379

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

kevinsung
Copy link
Contributor

The latest version of pytest fails with

_________________________________________ test_deprecated_test __________________________________________

    @deprecated_test
    def test_deprecated_test():
        warnings.simplefilter('error')
>       f()

_compat_test.py:51: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

args = (), kwargs = {}, cls = <class 'deprecation.DeprecatedWarning'>
the_warning = DeprecatedWarning('f', None, None, '')

    @functools.wraps(function)
    def _inner(*args, **kwargs):
        if should_warn:
            if is_unsupported:
                cls = UnsupportedWarning
            else:
                cls = DeprecatedWarning
    
            the_warning = cls(function.__name__, deprecated_in,
                              removed_in, details)
            warnings.warn(the_warning, category=DeprecationWarning,
>                         stacklevel=2)
E           deprecation.DeprecatedWarning: f is deprecated

@kevinsung kevinsung requested a review from viathor April 2, 2020 21:06
@googlebot googlebot added the cla: yes Tell googlebot to go away. label Apr 2, 2020
Copy link
Contributor

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, you need this to proceed with your work on the new release, so I'm approving, but I am concerned about this change, because the problem you're seeing means we won't be able to update pytest until this is resolved. Could you file an issue so we don't loose track of it?

@kevinsung
Copy link
Contributor Author

Filed #380

@kevinsung kevinsung merged commit e0ee00e into quantumlib:master Apr 2, 2020
@kevinsung kevinsung deleted the verify branch April 2, 2020 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Tell googlebot to go away.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants