-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bloq counts fails for LessThanGate / SingleQubitCompare decomposition #388
Comments
@tanujkhattar any idea? |
Looking into it now |
It's because the target qubit in Tl;Dr - The fix here is to change the signature of So this is less of a bug in the interop and more of a bug that arises due to old cirq-ft style implementation of the primitive where we didn't have directional registers. I'd imagine more such bugs would be discovered in other implementations and we can just fix them as we find them. I'll send a PR to fix this now. |
@fdmalone quantumlib/Cirq#6312 fixes the issue. It's hard to test the interop with the two codes living in separate repositories, but you can pull the Cirq PR, run I'm working on moving all Cirq-FT code to Qualtran and we can then have automated consistency checks for all Cirq-FT gate's using |
I'm just reopening this so we remember to bump the cirq_ft requirements. I guess I can do that during #350. |
This used to work with an older version of cirq_ft:
raises
Seems like the SingleQubitCompare is to blame
The text was updated successfully, but these errors were encountered: