Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SelectSwapQROM more idiomatic #699

Closed
mpharrigan opened this issue Feb 22, 2024 · 0 comments · Fixed by #1276
Closed

Make SelectSwapQROM more idiomatic #699

mpharrigan opened this issue Feb 22, 2024 · 0 comments · Fixed by #1276

Comments

@mpharrigan
Copy link
Collaborator

The figure from the paper looks like this

image

the current decomposition looks like

image

Some more intermediate-abstraction bloqs could clean this up. For example: the list of CNOTs could be wrapped in a bloq. The decomposition currently uses the cirq interop which does a lot of splitting and joining; as well as allocating. Perhaps more thoughtfully routing the registers with e.g. Partition could clean things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant