Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectSwapQROM maintenance #701

Closed
wants to merge 3 commits into from

Conversation

mpharrigan
Copy link
Collaborator

  • autodoc
  • fix docstrings to be valid markdown
  • remove the use of cirq.inverse which produces cirq._InverseCompositeGate which hurts my head
  • while I was at it: I changed the control flow of the construction to be more verbose.
  • sneak in a fix to the adjoint/t_complexity shim. Note: something like an Adjoint bloq is incompatible with the (vanilla) t complexity protocol because it involves leaping more than one level in the call graph.

This doesn't change the actual construction, cc #699

@mpharrigan
Copy link
Collaborator Author

Supporting cirq simulation via the bloq decomposition is borked. The error message fails trying to use cirq to simulate an Allocate bloq; but playing around with this I also got errors about a CNOT having the same source and target qubit.

@tanujkhattar tanujkhattar self-assigned this Feb 26, 2024
@mpharrigan mpharrigan closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants