Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more symbolic decompositions #1369

Merged
merged 8 commits into from
Aug 31, 2024
Merged

Support more symbolic decompositions #1369

merged 8 commits into from
Aug 31, 2024

Conversation

anurudhp
Copy link
Contributor

@anurudhp anurudhp commented Aug 30, 2024 •
edited
Loading

  • permutation bloqs: decompose for symbolic N
  • stateprep rotation - check phase bitsize, raise DecomposeTypeError when not possible.

@tanujkhattar
Copy link
Collaborator

I think it'll be nice to add some tests, but LGTM overall.

@mpharrigan
Copy link
Collaborator

yeah, this could use some symbolic bloq_examples

@anurudhp
Copy link
Contributor Author

anurudhp commented Aug 30, 2024 •
edited
Loading

Added some partially symbolic bloq examples along with a assert_valid_bloq_decomposition test for them

mpharrigan
mpharrigan reviewed Aug 30, 2024
View reviewed changes
qualtran/bloqs/arithmetic/permutation_test.py
Comment on lines +81 to +82
def test_decomposition(bloq_ex):
qlt_testing.assert_valid_bloq_decomposition(bloq_ex.make())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant with the bloq_autotester

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to verify that the bloq actually decomposes (i.e. without raising a DecomposeTypeError). bloq_autotester treats DecomposeTypeError as a success right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good point. (technically it would report it as a skip)

@anurudhp anurudhp enabled auto-merge (squash) August 31, 2024 00:03
@anurudhp anurudhp merged commit f4ec2cc into quantumlib:main Aug 31, 2024
8 checks passed
@anurudhp anurudhp deleted the 2024/08/29-more-symbolic-decomps branch August 31, 2024 00:22
@anurudhp anurudhp mentioned this pull request Sep 1, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan left review comments

@tanujkhattar tanujkhattar tanujkhattar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anurudhp @tanujkhattar @mpharrigan