QCQMC Part 7: Add Experiment classes #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
reviewed
Jul 2, 2024
| from recirq.qcqmc.trial_wf import TrialWavefunctionData | ||
|
|
||
|
|
||
| def test_small_experiment_raw_samples_shape( |
There was a problem hiding this comment.
This test file seems short. Does it test everything in experiments?
There was a problem hiding this comment.
It does at least call every function (after a small update) but the test coverage is not great. I'd need @wjhuggins to help writing some sensible physics tests of the shadow tomography protocol but I think that can be a follow up (we discussed writing some better documentation of the shadow tomography part of the code which is probably of most interest to QIS people).
There was a problem hiding this comment.
Ok, yeah, let's make it a follow up PR.
dstrain115
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends upon #351 and #353: Adds the Experiment class which packages everything together to run a simulated experiment.