Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect matrix being used in ApplyGateDagger. #272

Merged
merged 5 commits into from
Jan 26, 2021
Merged

Fixes incorrect matrix being used in ApplyGateDagger. #272

merged 5 commits into from
Jan 26, 2021

Conversation

MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Jan 26, 2021 •
edited
Loading

The controlled gate case of ApplyGateDagger would use the undaggered version of the gates matrix. Found to be blocking on tensorflow/quantum#458

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Jan 26, 2021
@MichaelBroughton MichaelBroughton mentioned this pull request Jan 26, 2021
Open
@MichaelBroughton MichaelBroughton added the kokoro:run Trigger Kokoro builds for this PR. label Jan 26, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jan 26, 2021
sergeisakov
sergeisakov approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@sergeisakov sergeisakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that.

tests/simulator_testfixture.h Outdated Show resolved Hide resolved
tests/simulator_testfixture.h Outdated Show resolved Hide resolved
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Jan 26, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jan 26, 2021
@95-martin-orion 95-martin-orion merged commit 3824fb2 into quantumlib:master Jan 26, 2021
@MichaelBroughton MichaelBroughton deleted the dagger_fix branch June 29, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc left review comments

@sergeisakov sergeisakov sergeisakov approved these changes

@95-martin-orion 95-martin-orion Awaiting requested review from 95-martin-orion

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelBroughton @Strilanc @sergeisakov @95-martin-orion @qsim-qsimh-bot