Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor quantum trajectory simulator. #312

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Refactor quantum trajectory simulator. #312

merged 2 commits into from
Mar 18, 2021

Conversation

sergeisakov
Copy link
Collaborator

Closes #311

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Mar 17, 2021
MichaelBroughton
MichaelBroughton approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

95-martin-orion
95-martin-orion requested changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nitpicks.

Thank you for the multitude of qsimcirq cleanup items in this PR as well! I think the separation of names in qtrajectory will help as well.

pybind_interface/pybind_main.h
@@ -216,7 +216,10 @@ PYBIND11_MODULE(qsim, m) {
.def_readwrite("num_qubits", &Circuit::num_qubits)
.def_readwrite("gates", &Circuit::gates);

py::bind_vector<NoisyCircuit>(m, "NoisyCircuit");
py::class_<NoisyCircuit>(m, "NoisyCircuit")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should allow us to remove the PYBIND_MAKE_OPAQUE line at the top of the file:

qsim/pybind_interface/pybind_main.h

Line 32 in 6ad4cd5

PYBIND11_MAKE_OPAQUE(qsim::NoisyCircuit<qsim::Cirq::GateCirq<float>>);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

qsimcirq/qsim_simulator.py Outdated
Raises:
ValueError if internal keys 'c' or 'i' are included in 'qsim_options'.
ValueError if internal keys 'c', 'i' or 's'are included in 'qsim_options'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"or 's'are" -> "or 's' are"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Mar 18, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Mar 18, 2021
@95-martin-orion 95-martin-orion merged commit f729d83 into master Mar 18, 2021
@MichaelBroughton MichaelBroughton mentioned this pull request Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support other for objects in qtrajectory
4 participants
@sergeisakov @MichaelBroughton @95-martin-orion @qsim-qsimh-bot