Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cibuildwheel version #610

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

vtomole
Copy link
Contributor

@vtomole vtomole commented May 3, 2023

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label May 3, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label May 3, 2023
@95-martin-orion
Copy link
Collaborator

To remind myself: we should be able to view the generated wheels in the Build all wheels for testing logs to confirm that this does what we need it to do.

@95-martin-orion
Copy link
Collaborator

From the error logs, it looks like we also need to update our pybind version. pybind11==2.10.1 is the first version with python 3.11 support (docs), and we set the version here.

@vtomole
Copy link
Contributor Author

vtomole commented May 3, 2023

Updated to minimum pybind version to 2.10.1.

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label May 3, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label May 3, 2023
@vtomole
Copy link
Contributor Author

vtomole commented May 3, 2023

@95-martin-orion Looks like this PR generates a qsimcirq-0.16.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl. Will we need to cut a new release once this is in?

@95-martin-orion
Copy link
Collaborator

@95-martin-orion Looks like this PR generates a qsimcirq-0.16.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl. Will we need to cut a new release once this is in?

Yup, same as before. All PRs generate wheels - and in theory you could use them, if sufficiently motivated - but they aren't included in pip install qsimcirq until they're built into a release.

@95-martin-orion 95-martin-orion merged commit fb6106d into quantumlib:master May 3, 2023
@vtomole
Copy link
Contributor Author

vtomole commented May 3, 2023

@95-martin-orion No, thank you 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants