Use bazel-contrib/setup-bazel instead of manually installing a deb during CI #665
Conversation
…ring CI Also fix some EOL whitespace because that's how my vim is configured.
| @@ -22,12 +22,14 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: bazel-contrib/setup-bazel@0.8.5 | |||
There was a problem hiding this comment.
It's not immediately clear to me how (or if) this specifies the bazel version to install. IIRC, this is important for qsim as it needs to align with the bazel version used in TFQ for compatibility reasons.
Can we lock the bazel version to 5.3.0 here?
There was a problem hiding this comment.
The bazel version is locked by .bazelversion in the root of the repo, and that's already set to 5.3.0.
setup-bazel will install bazelisk 1.x as bazel and then any time bazel is called, bazelisk will download and install the bazel version defined by .bazelversion if the file exists (which it does 🙃)
More info on how bazelisk determines which version of bazel to run can be found here: https://github.com/bazelbuild/bazelisk?tab=readme-ov-file#how-does-bazelisk-know-which-bazel-version-to-run
|
BTW, the context for this is https://github.com/qh-lab/pyle/pull/46833#issuecomment-2204296035 |
|
@dougthor42 - #672 fixed the CI failures. If you're still interested in getting this merged, resolve conflicts and retry. If I'm not available for final approval, request review from @pavoljuhas. |
|
Conflicts fixed, please approve CI run. |
Use
bazel-contrib/setup-bazelinstead of manually installing a deb during CIAlso fix some EOL whitespace because that's how my vim is configured.
@95-martin-orion