Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 183 #185

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Issue 183 #185

merged 5 commits into from
Sep 13, 2024

Conversation

myrmarachne
Copy link
Member

No description provided.

Karolina Cynk added 2 commits September 2, 2024 15:20
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 40.67797% with 35 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (6cbbd53) to head (2ebff56).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../data_providers/bloomberg/tabular_data_provider.py 13.63% 19 Missing ⚠️
...ata_providers/bloomberg/bloomberg_data_provider.py 5.88% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   77.04%   77.03%   -0.01%     
==========================================
  Files         227      227              
  Lines        9151     9180      +29     
==========================================
+ Hits         7050     7072      +22     
- Misses       2101     2108       +7     
Files with missing lines Coverage Δ
...erg_beap_hapi/bloomberg_beap_hapi_data_provider.py 44.01% <100.00%> (+2.12%) ⬆️
...ata_providers/bloomberg/bloomberg_data_provider.py 41.77% <5.88%> (-3.13%) ⬇️
.../data_providers/bloomberg/tabular_data_provider.py 23.91% <13.63%> (+3.91%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbbd53...2ebff56. Read the comment docs.

@myrmarachne myrmarachne merged commit 78d9499 into master Sep 13, 2024
5 of 7 checks passed
@myrmarachne myrmarachne deleted the beap_hapi_data_provider/issue_183 branch September 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BloombergBeapHapiDataProvider.get_tickers_universe returns only the first 2500 members of an index
3 participants