-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve documentation for users #188
Fix/improve documentation for users #188
Conversation
Improve documentation auto-generated in API docs
I found working with the provided containers to be difficult, so I added a bit of extra documentation that will hopefully help other users
Add notes on implementing a data-provider, as I found the documentation to be lacking on expected return values and discovered them manually through permutation
Saw the wf failed Let me check the styling and update |
Hi Robert, Thank you for your contribution, we will merge the changes to the docstrings once the pipeline succeeds. As for the issues with styling, you can run Let me know if you have any further comments. |
Took your suggestion and ran flake8. Fixed up the whitespace errors it was complaining about |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 76.93% 77.06% +0.13%
==========================================
Files 227 227
Lines 9180 9180
==========================================
+ Hits 7063 7075 +12
+ Misses 2117 2105 -12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
After spending a fairly considerable amount of time splunking around the library and configuring things to work properly I figured I'd update the documentation so other users will have an easier time understanding how to make use of what is provided here