Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve documentation for users #188

Merged

Conversation

RobertLD
Copy link
Contributor

After spending a fairly considerable amount of time splunking around the library and configuring things to work properly I figured I'd update the documentation so other users will have an easier time understanding how to make use of what is provided here

Improve documentation auto-generated in API docs
I found working with the provided containers to be difficult, so I added a bit of extra documentation that will hopefully help other users
Add notes on implementing a data-provider, as I found the documentation to be lacking on expected return values and discovered them manually through permutation
@RobertLD
Copy link
Contributor Author

Saw the wf failed Let me check the styling and update

@eirik-thorp
Copy link
Collaborator

Hi Robert,

Thank you for your contribution, we will merge the changes to the docstrings once the pipeline succeeds.

As for the issues with styling, you can run flake8 on your end to see the issues, there seems to be some trailing whitespaces in the docstrings that's triggering some errors in the pipeline.

Let me know if you have any further comments.

@RobertLD
Copy link
Contributor Author

Hi Robert,

Thank you for your contribution, we will merge the changes to the docstrings once the pipeline succeeds.

As for the issues with styling, you can run flake8 on your end to see the issues, there seems to be some trailing whitespaces in the docstrings that's triggering some errors in the pipeline.

Let me know if you have any further comments.

Took your suggestion and ran flake8. Fixed up the whitespace errors it was complaining about

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.06%. Comparing base (78d9499) to head (3660568).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   76.93%   77.06%   +0.13%     
==========================================
  Files         227      227              
  Lines        9180     9180              
==========================================
+ Hits         7063     7075      +12     
+ Misses       2117     2105      -12     
Files with missing lines Coverage Δ
...lib/data_providers/abstract_price_data_provider.py 34.73% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d9499...3660568. Read the comment docs.

@myrmarachne myrmarachne merged commit df4bb7a into quarkfin:master Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants