Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven-compiler-plugin into pluginManagement #103

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

majguo
Copy link
Contributor

@majguo majguo commented Jun 7, 2023

Signed-off-by: Jianguo Ma <jiangma@microsoft.com>
@majguo
Copy link
Contributor Author

majguo commented Jun 7, 2023

Hello @gastaldi, could you pls take a look? Thanks.

@gastaldi
Copy link
Member

gastaldi commented Jun 7, 2023

You mean maven-compiler-plugin, not maven-source-plugin, right? 😀

@gastaldi gastaldi changed the title Add maven-source-plugin into pluginManagement Add maven-compiler-plugin into pluginManagement Jun 7, 2023
@gastaldi gastaldi merged commit 8022a75 into quarkiverse:main Jun 7, 2023
@gastaldi
Copy link
Member

gastaldi commented Jun 7, 2023

@all-contributors add @majguo for code

@allcontributors
Copy link
Contributor

@gastaldi

I've put up a pull request to add @majguo! 🎉

@majguo
Copy link
Contributor Author

majguo commented Jun 7, 2023

You mean maven-compiler-plugin, not maven-source-plugin, right? 😀

Ah, correct, thanks for fixing the typo 😀

@majguo majguo deleted the majguo/mvn-src-plugin branch June 7, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants